From: Patrick Steinhardt Date: Mon, 28 Sep 2026 07:41:46 GMT Subject: Re: [PATCH 0/2] replay: add signing support Message-ID: In-Reply-To: <20260925205348.1210154-1-pmonette@google.com> Hi, On Fri, Sep 25, 2026 at 04:53:46PM -0400, Patrick Monette wrote: > This pair of commits fixes a FIXME in replay.c. With this, it's possible > to sign commits using `git replay`. > > To follow the convention of git plumbing commands, where they must > behave the same regardless of user config, `commit.gpgSign` is > intentionally ignored. > > The first patch fixes pick_regular_commit() to ensure failures to create > commits are correctly handled, which can now happen more easily because > of signing. Note that there's already a patch series in flight that's adding the infra to sign commits at [1]. Your patches will conflict with that series, even though you're ultimately adapting git-replay(1) and not git-history(1). So I'd suggest that once the series at [1] land, you can maybe rebase your changes and then send a new version. Patrick [1]: <20260912160045.36064-1-git@5ouma.me>