From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 23 Sep 2026 12:21:13 GMT
Subject: Re: [PATCH] reflog: fix default expiry periods
Message-ID: <arPEOdE9SKyOd8EJ@pks.im>
In-Reply-To: <20260922180251.GA18803@coredump.intra.peff.net>

On Tue, Sep 22, 2026 at 02:02:51PM -0400, Jeff King wrote:
> On Tue, Sep 22, 2026 at 10:27:38AM -0700, Junio C Hamano wrote:
> 
> > Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:
> > 
> > > The default expiry periods for reflog entries are reversed in
> > > REFLOG_EXPIRE_OPTIONS_INIT(). This causes reachable entries to
> > > expire after 30 days instead of the documented 90 days.
> > >
> > > Restore the intended 90-day expiry for reachable entries and
> > > 30-day expiry for unreachable entries.
> > >
> > > Add a regression test for a reachable reflog entry that is
> > > 60 days old.
> > 
> > Does this breakage date back to the beginning of the reflog expire
> > feature, or was it working perfectly fine but was broken sometime
> > ago?  Do we know where the breakge happened, and why?  Those are a
> > lot more relevant things to describe in the first paragraph.  Once
> > the problem is described clearly enough in a simple case like this,
> > the solution to the problem is so obvious that latter two paragraphs
> > do not need to be said.
> 
> I had the same question. They were flipped by 8565827570
> (builtin/reflog: stop storing default reflog expiry dates globally,
> 2025-04-08). That definitely should go in the commit message.

Oops, indeed. Thanks for finding this issue and fixing it!

Patrick