From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 30 Sep 2026 12:48:36 GMT
Subject: Re: [PATCH 7/7] gitlab-ci: fix hanging MSVC jobs
Message-ID: <ar0FJP9cAWFY7SZa@pks.im>
In-Reply-To: <CAOLa=ZShU_FhuudX6JSPO7q6w9xBR-QRyEd1UbCZ15o-S3xtqQ@mail.gmail.com>

On Wed, Sep 30, 2026 at 05:26:17AM -0700, Karthik Nayak wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/ci/install-dependencies.ps1 b/ci/install-dependencies.ps1
> > index e3b367fa54..2ceb5dd99a 100755
> > --- a/ci/install-dependencies.ps1
> > +++ b/ci/install-dependencies.ps1
> > @@ -53,3 +53,11 @@ Invoke-Installer msiexec.exe @('/i', $mesonMsi, 'INSTALLDIR=C:\Meson', '/quiet',
> >  $rustMsi = Get-Installer "rust.msi" `
> >      "https://static.rust-lang.org/dist/rust-$RustVersion-x86_64-pc-windows-msvc.msi"
> >  Invoke-Installer msiexec.exe @('/i', $rustMsi, 'INSTALLDIR=C:\Rust', 'ADDLOCAL=Rustc,Cargo,Std', '/quiet', '/norestart')
> > +
> > +# Disable Git Credential Manager, which is auto-configured by PortableGit.
> > +# GitLab's runner picks up this Git in its cleanup stage and runs `git
> > +# credential reject`, which hangs in GCM and makes the job time out.
> > +& "C:\Program Files\Git\bin\git.exe" config unset --all --system credential.helper
> > +if ($LASTEXITCODE -ne 0 -and $LASTEXITCODE -ne 5) {
> > +    throw "Failed to unset credential.helper with exit code $LASTEXITCODE"
> > +}
> >
> 
> Nice, for reference the runner team also has a fix on their end to
> disable credential.helper on their side too [1].
> 
> [1]: gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/7470

Yeah, I've seen that already, but thanks for pointing this out to the
mailing list. I guess it makes sense to apply this patch anyway so that
we don't have this issue anymore with the current-broken version of the
runner.

Thanks!

Patrick