From: Patrick Steinhardt Date: Fri, 11 Sep 2026 19:01:41 GMT Subject: Re: What's cooking in git.git (Sep 2026, #04) Message-ID: In-Reply-To: On Fri, Sep 11, 2026 at 08:53:57AM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: > > On Thu, Sep 10, 2026 at 10:39:02AM -0700, Junio C Hamano wrote: > >> * ps/libgit-in-subdir (2026-07-12) 2 commits > >> . Move libgit.a sources into separate "lib/" directory > >> . t/helper: prepare "test-example-tap.c" for introduction of "lib/" > >> . Merge branch 'ps/odb-source-packed' into ps/libgit-in-subdir > >> > >> The source files for 'libgit.a' have been moved into a new 'lib/' > >> directory to clean up the top-level directory and clearly separate > >> library code. This topic has been ejected for now, as it causes too > >> many evil merges with other topics. > >> ... > > I didn't really have the feeling that I was gaining consensus on this > > series. Maybe I'll be able to build consensus at the Contributor's > > Summit, but until then we can probably just discard this series. > > To be fair, I do not think anybody would unwelcome a change that > makes the sources easier to navigate---otherwise we wouldn't have > odb/ or even builtin/ hierarchies today. It is just that different > people views how easier to navigate a concrete change proposed makes > the sources. Yeah. Thing is, changes like this are always going to be subjective. I expected lots of discussion around this particular one, so I knew that it was quite likely that I won't be able to build consensus and that there'd be lots of different opinions. I personally still think that having library sources properly split out into its own hierarchy is a sensible first step. But I also agree with others that it makes sense to then further group files that belong to specific subsystems into their own directories. I don't really see these as mutually exclusive, we can have both. Patrick