From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 09 Sep 2026 05:57:58 GMT
Subject: Re: [PATCH v3 0/3] sequencer: leave auto maintenance to the end of a sequence
Message-ID: <aqD1ZlaLsJ7K04Bw@pks.im>
In-Reply-To: <xmqqse3jyc2m.fsf@gitster.g>

On Tue, Sep 08, 2026 at 08:53:05AM -0700, Junio C Hamano wrote:
> "Thomas Bachem via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > Changes since v2:
> >
> >  * Auto maintenance now runs from builtin/rebase.c and builtin/revert.c,
> >    once the command is done, instead of from three places inside the
> >    sequencer. That follows the apply backend, where "git am" leaves it to
> >    rebase.c (Patrick, Phillip).
> >  * gc.auto=0 dropped, maintenance.auto=false is enough (Patrick).
> >  * config_parameters is a char * built once with strbuf_detach() (Junio).
> >  * Patch 3 extends the tests of patch 2 instead of adding its own. They also
> >    assert that nothing runs before a stop, and cover a single pick with
> >    --edit and a sequence ending in --skip (Phillip).
> >  * Commit messages rewritten: what GIT_CONFIG_PARAMETERS is and looks like
> >    (Patrick), what patch 2 changes for the user and why the call moved
> >    (Patrick, Phillip), and the comment on the helper (Phillip).
> >
> > Based on master. Independent of the rerere lock fix in [1].
> 
> Will queue.
> 
> By the way, is it just me or are proposed log messages getting
> longer and longer with more irrelevant detaild these days?
> 
> If it is not just my imagination, this trend must stop.

It's not your imagination, it's gotten quite a bit worse over the last
couple weeks. I also started to push back on this trend, see [1] for
example.

Thanks!

Patrick

[1]: <ap-iEoeY7XKjeZgL@pks.im>