From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 31 Aug 2026 09:27:38 GMT
Subject: Re: [PATCH v5 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec
Message-ID: <apVJCt4prIi2GgXp@pks.im>
In-Reply-To: <01cd487cd23f23b1d18359b86fbcf18e25039e6d.1788010335.git.ben.knoble@gmail.com>

On Sat, Aug 29, 2026 at 09:38:20AM -0400, D. Ben Knoble wrote:
> diff --git a/builtin/update-index.c b/builtin/update-index.c
> index 241abd4332..8e0c25655f 100644
> --- a/builtin/update-index.c
> +++ b/builtin/update-index.c
> @@ -130,7 +130,7 @@ static void xrmdir(const char *path)
>  static void avoid_racy(void)
>  {
>  	/*
> -	 * not use if we could usleep(10) if USE_NSEC is defined. The
> +	 * not use if we could usleep(10) if core.useNanosec is defined. The

Micronit: s/defined/enabled/

Otherwise I'm happy with this patch. It looks a lot better now that we
use less preprocessor directives. Thanks!

Patrick