From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 31 Aug 2026 08:14:05 GMT
Subject: Re: [PATCH 6/8] odb/source: support writing alternates when creating the database
Message-ID: <apU3zShTb3W3rit9@pks.im>
In-Reply-To: <8733vyuwid.fsf@emacs.iotcl.com>

On Fri, Aug 28, 2026 at 04:53:30PM +0200, Toon Claes wrote:
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/odb/source.h b/odb/source.h
> > index ea8675247e..86b82fab3b 100644
> > --- a/odb/source.h
> > +++ b/odb/source.h
> > @@ -5,6 +5,7 @@
> >  #include "object.h"
> >  #include "odb.h"
> >  #include "odb/transaction.h"
> > +#include "strvec.h"
> 
> I see `struct strvec;` is already defined below
> odb_source_type_to_name(). Can we not include this and put the new
> struct below the strvec definition?

Good point, will do.

Patrick