From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 19 Aug 2026 11:13:17 GMT
Subject: Re: [PATCH v3 1/4] completion: add 'git history' subcommands
Message-ID: <aoWPzTx0OUgg0mzH@pks.im>
In-Reply-To: <20260813-history_autocompletion-v3-1-69eed1cea93a@kernel.org>

On Thu, Aug 13, 2026 at 09:05:02PM +0200, Vincent Mailhol wrote:
> Changes in v3:
> 
>   - Ignore the split "<option> <value>" syntax for options that take
>     arguments. This simplifies revision detection and avoids hard-coding
>     option names.
>   - Test that options are not completed before a subcommand.

Yeah, this version is a lot more maintainable. It will have false
positives, but I think we shouldn't let perfect be the enemy of good.

Patrick