From: Patrick Steinhardt <ps@pks.im>
Date: Mon, 10 Aug 2026 12:50:26 GMT
Subject: Re: [PATCH 3/3] core: convert build-time USE_NSEC into runtime core.useNanosec
Message-ID: <annJEmkSoRIrhbpx@pks.im>
In-Reply-To: <dbbd96d50811e4c2decb6f754b56dc1f7ee0944a.1786103607.git.ben.knoble@gmail.com>

On Fri, Aug 07, 2026 at 07:56:26AM -0400, D. Ben Knoble wrote:
> diff --git a/compat/posix.h b/compat/posix.h
> index e2e794cad7..51ee03233b 100644
> --- a/compat/posix.h
> +++ b/compat/posix.h
> @@ -487,7 +487,6 @@ int git_qsort_s(void *base, size_t nmemb, size_t size,
>  } while (0)
>  
>  #ifdef NO_NSEC
> -#undef USE_NSEC
>  #define ST_CTIME_NSEC(st) 0
>  #define ST_MTIME_NSEC(st) 0
>  #else

Ah, I was about to ask whether all platforms even support nanoseconds.
But I wasn't aware that we have both NO_NSEC and USE_NSEC, so we still
know to not use nanoseconds if unsupported by the platform.

Patrick