From: Patrick Steinhardt Date: Wed, 05 Aug 2026 06:06:19 GMT Subject: Re: [PATCH 5/7] odb/streaming: consolidate read and write streams Message-ID: In-Reply-To: On Tue, Aug 04, 2026 at 01:23:42PM -0500, Justin Tobler wrote: > On 26/08/04 09:25AM, Patrick Steinhardt wrote: > > diff --git a/builtin/unpack-objects.c b/builtin/unpack-objects.c > > index 7439ec53be..05a2d48011 100644 > > --- a/builtin/unpack-objects.c > > +++ b/builtin/unpack-objects.c > > @@ -359,20 +359,21 @@ static void unpack_non_delta_entry(enum object_type type, unsigned long size, > > } > > > > struct input_zstream_data { > > + struct odb_stream base; > > git_zstream *zstream; > > int status; > > }; > > Ok, as mentioned in the commit message, we now embed the stream instead > storing a pointer to the extra data. Should we also update the struct > name here now that `input_zstream_data` is really itself a stream? I intentionally didn't rename anything in this commit here to keep churn minimal, and deferred the renames into subsequent commits. I should've noted that in the commit message though. This one structure I didn't rename though. I'll add a commit. Patrick