From: Taylor Blau Date: Fri, 17 Jul 2026 23:18:24 GMT Subject: Re: [PATCH 4/4] last-modified: keep per-path Bloom filters for wildcard pathspecs Message-ID: In-Reply-To: <20260717-toon-speed-up-last-modified-v1-4-410418f18614@iotcl.com> On Fri, Jul 17, 2026 at 05:47:02PM +0200, Toon Claes wrote: > Restore `bloom_filter_settings` after prepare_revision_walk() so the > per-path check keeps working for wildcard pathspecs. Could we add a test which actually exercises this? t8020 never writes a commit-graph with --changed-paths, so these new Bloom paths remain dormant. The existing "last-modified subdir with wildcard non-recursive" case passes a/* unquoted, so the shell expands it into literal pathspecs before last-modified sees it. Writing a changed-path commit-graph and using a genuinely quoted top-level wildcard, e.g.: check_last_modified -r "*" , would cover the zero-prefix wildcard case here. -r is necessary since the default max-depth rejects a true wildcard pathspec. (To be clear, I don't think that there is a correctness issue here, but I do think we have a gap in test coverage in this patch.) Thanks, Taylor