From: Jan Engelhardt Date: Wed, 14 Jan 2009 13:06:12 GMT Subject: Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Message-ID: In-Reply-To: <7vsknm2kbs.fsf@gitster.siamese.dyndns.org> On Wednesday 2009-01-14 12:33, Junio C Hamano wrote: >> git-daemon: use getnameinfo to resolve hostname >> >> This is much shorter than inet_ntop'ing, and also translated >> unresolvable addresses into a string. > >translated? (I think you meant "translates" but my English is bad, so I >am double checking). yes, keyboard slipped away. >This indeed is much nicer, provided if it is available at least as widely >as inet_ntop() is. Both inet_ntop and getnameinfo are in POSIX.1-2001. > (1) Do we need similar compat/ function for getnameinfo()? I am guessing > that most likely places are the ones that need NO_INET_NTOP and > NO_INET_PTON, and googling seems to indicate old Cygwin and HP-UX > 11.00 may be among them. > > (2) Do we still use inet_ntop() elsewhere, and if not, can we remove the > compat/ definitions? > Yes, it is still used elsewhere.