From: Johannes Schindelin Date: Mon, 24 Mar 2008 20:03:04 GMT Subject: Re: [PATCH 3/2] parse-options.c: introduce OPT_DATE Message-ID: In-Reply-To: <200803241725.42940.barra_cuda@katamail.com> Hi, On Mon, 24 Mar 2008, Michele Ballabio wrote: > On Monday 24 March 2008, Michele Ballabio wrote: > > +               OPT_DATE(0, "expire", &expire, > > [...] > > > +#define OPT_DATE(s, l, v, h) \ > > Ooops. To be consistent, these should be OPT__DATE (with two > underscores) instead (and in the commit message, too). I thought OPT__BLA was reserved for --bla options? IOW OPT__DATE would not be usable to implement --expire, but only --date. I might be wrong, though. Ciao, Dscho