From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 23 Mar 2008 22:33:56 GMT
Subject: Re: [PATCH 3/4] Add a function for get the parents of a commit
Message-ID: <alpine.LSU.1.00.0803232332150.4353@racer.site>
In-Reply-To: <1206308562-31489-3-git-send-email-joerg@alea.gnuu.de>

Hi,

On Sun, 23 Mar 2008, Jörg Sommer wrote:

> 
> Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>

"for get"?  You mean "to get".

> +parents_of_commit() {
> +	git rev-list --parents -1 "$1" | cut -d' ' -f2-
> +}

>From the rest of Git's source code, I would have expected this to be 
called "get_parents", and to have a space before the parens.  In general, 
it is always good to imitate the style around the code you are writing.

Ciao,
Dscho