From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 23 Mar 2008 22:26:38 GMT
Subject: Re: [PATCH 1/4] Move redo merge code in a function
Message-ID: <alpine.LSU.1.00.0803232322310.4353@racer.site>
In-Reply-To: <1206308562-31489-1-git-send-email-joerg@alea.gnuu.de>

Hi,

On Sun, 23 Mar 2008, Jörg Sommer wrote:

> 
> Signed-off-by: Jörg Sommer <joerg@alea.gnuu.de>

I like the patch, but the commit message is not really meaningful if you 
do not read the patch.  Maybe you want to prefix it with "rebase -i:"?  
And _just_ maybe you want to give an explanation what you want to do with 
it?

(For reference, I think the recent patch series by Linus is a _wonderful_ 
example how to do it: it has a very informative cover letter, and each 
patch tells you more about what and why, leaving the how mostly to the 
patch.  Basically, it is a pleasure to read (and understand):

http://article.gmane.org/gmane.comp.version-control.git/77827)

Ciao,
Dscho