From: Johannes Schindelin Date: Tue, 11 Mar 2008 15:18:08 GMT Subject: Re: [PATCH 03/10] Make get_git_dir() and 'git rev-parse --git-dir' absolute path Message-ID: In-Reply-To: Hi, On Tue, 11 Mar 2008, Nguyen Thai Ngoc Duy wrote: > On Tue, Mar 11, 2008 at 8:20 PM, Johannes Schindelin > wrote: > > > On Sun, 2 Mar 2008, Nguyễn Thái Ngọc Duy wrote: > > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > > > I do not like this change. It is IMO completely unnecessary, and > > might break assumptions. > > It could. And I tried my best to make sure it did not break anything. That is contradicting. I think that whatever you tried, once you let rev-parse --git-dir return only absolute paths, you already risked breakage. Besides, I remember that Junio specifically requested that I would _not_ do something like that (this was for --show-cdup, but I think it really applies here, too). > While it's not really necessary, it would be IMHO a good change as you > would not have to rely on `cwd` anymore (that would mean whether moving > cwd by prefix or not would no longer matter). I do not see the problem. And therefore I do not see that this patch solves anything. Ciao, Dscho