From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 08 Mar 2008 23:18:16 GMT
Subject: Re: [PATCH 05/11] Add a library function to add an alternate to the alternates file
Message-ID: <alpine.LSU.1.00.0803090017150.3975@racer.site>
In-Reply-To: <alpine.LNX.1.00.0803081804090.19665@iabervon.org>

Hi,

On Sat, 8 Mar 2008, Daniel Barkalow wrote:


> +void add_to_alternates_file(const char *reference)
> +{
> +	char *file;
> +	char *alt;
> +	int fd;
> +
> +	file = mkpath("%s/objects/info/alternates", get_git_dir());
> +	fd = open(file, O_CREAT | O_WRONLY | O_APPEND, 0666);
> +	if (fd < 0)
> +		die("failed to create %s", file);

Even with alternates, which are probably written only rarely, I would have 
expected a lockfile procedure (if only to be consistent with the rest).

Ciao,
Dscho