From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 04 Mar 2008 16:13:31 GMT
Subject: Re: [PATCH] git-submodule: Don't die when command fails for one submodule
Message-ID: <alpine.LSU.1.00.0803041612400.22527@racer.site>
In-Reply-To: <46dff0320803040806y5ed02b86p9216ddc752f3052@mail.gmail.com>

Hi,

On Wed, 5 Mar 2008, Ping Yin wrote:

> On Wed, Mar 5, 2008 at 12:03 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>
> >  On Wed, 5 Mar 2008, Ping Yin wrote:
> >
> >  > The error output is not lost and is in module_name
> >
> >  That's what I am saying: the error output is not enough.  The exit status
> >  needs to indicate that there was an error, too.  Everything else is
> >  unusable by scripts.
> 
> I think this can be done in a following patch which capture any error
> and give the right exit status.

That's horrible!  Are you seriously suggesting breaking a perfectly fine 
paradigm in one patch, just to fix it in the next one?

*Shudders*,
Dscho