From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 04 Mar 2008 12:04:12 GMT
Subject: Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin
Message-ID: <alpine.LSU.1.00.0803041203320.22527@racer.site>
In-Reply-To: <0t4pbmaew9.wl%bremner@pivot.cs.unb.ca>

Hi,

On Tue, 4 Mar 2008, David Bremner wrote:

> >>>>> "Junio" == Junio C Hamano <gitster@pobox.com> writes:
> 
>     Junio> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
>     >> Pardon my ignorance, but what business has metastore reading
>     >> stdin?  There should be nothing coming in, so the change you
>     >> mentioned should be correct, and your hook relies on something
>     >> it should not rely on.
> 
>     Junio> It is not metastore.  It is an interactive hook that reads
>     Junio> from the user who is sitting on the terminal and invoked
>     Junio> the git-commit program.
> 
> Yeah, I should have been more explicit. The problem is a line 
> 
>       read -N1 VAR

Can you be even more explicit?  IOW why does this have to be a pre-commit 
hook, and cannot be done before calling git-commit itself?

Ciao,
Dscho