From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 02 Mar 2008 15:57:02 GMT
Subject: Re: [PATCH] Make the exit code of add_file_to_index actually useful
Message-ID: <alpine.LSU.1.00.0803021555500.22527@racer.site>
In-Reply-To: <20080302154238.GD2973@steel.home>

Hi,

On Sun, 2 Mar 2008, Alex Riesen wrote:

> -			add_file_to_cache(path, verbose);
> +			if (add_file_to_cache(path, verbose))
> +				exit(1);

Does it really, really _have_ to be exit(1)?  I mean, now you block even 
the faintest chance that we can libify libgit.a by overriding die_routine.

A "return -1" might make _much_ more sense, too.

Ciao,
Dscho