From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 28 Feb 2008 15:53:48 GMT
Subject: Re: [PATCH 4/9] Make setup_work_tree() return new prefix
Message-ID: <alpine.LSU.1.00.0802281552530.22527@racer.site>
In-Reply-To: <fcaeb9bf0802280502m2cfc967bt792be98d81a2996@mail.gmail.com>

Hi,

On Thu, 28 Feb 2008, Nguyen Thai Ngoc Duy wrote:

> On Thu, Feb 28, 2008 at 6:30 PM, Johannes Schindelin 
> <Johannes.Schindelin@gmx.de> wrote:
>
> > I am sorry, but with all these intrusive changes, I get a very uneasy 
> > feeling.  As uneasy as with the original series, which I tried to fix 
> > up, not really succeeding.
> 
> In constrast I feel good :) To me setup_git_directory*() at the end look 
> really nice. No chdir() all over the place (temporary chdir() for 
> detecting .git does not count). It also gives a chance to get rid of 
> worktree to commands that do not care about worktree at all.

Well, I'll have to review your patches in depth, then.  Which will take 
some days, because I wanted to submit builtin-remote first.

Ciao,
Dscho