From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 28 Feb 2008 15:28:34 GMT
Subject: Re: [PATCH 22/40] Windows: Implement asynchronous functions as threads.
Message-ID: <alpine.LSU.1.00.0802281525510.22527@racer.site>
In-Reply-To: <1204138503-6126-23-git-send-email-johannes.sixt@telecom.at>

Hi,

On Wed, 27 Feb 2008, Johannes Sixt wrote:

> In upload-pack we must explicitly close the output channel of rev-list. 
> (On Unix, the channel is closed automatically because process that runs 
> rev-list terminates.)

When I read this patch, my impression was that it litters the source code 
with #ifdef's.  IMO this makes the code less readable, and as a 
consequence easer to fsck up.

Unfortunately, I have no idea how to help that, other than implementing 
compat/thread.[ch], abstracting the thread functions, and introducing a 
NO_FORK Makefile variable and preprocessor constant.

Hmpf.

Ciao,
Dscho