From: Johannes Schindelin Date: Thu, 28 Feb 2008 12:21:35 GMT Subject: Re: [PATCH 13/40] Windows: Fix PRIuMAX definition. Message-ID: In-Reply-To: <1204138503-6126-14-git-send-email-johannes.sixt@telecom.at> Hi, On Wed, 27 Feb 2008, Johannes Sixt wrote: > diff --git a/git-compat-util.h b/git-compat-util.h > index 3b57464..c576f5a 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -103,7 +103,11 @@ > #endif > > #ifndef PRIuMAX > +#ifndef __MINGW32__ > #define PRIuMAX "llu" > +#else > +#define PRIuMAX "I64u" > +#endif > #endif Would this not be better as a patch to Makefile, extending the COMPAT_CFLAGS with -DPRIuMAX=\"I64u\"? Ciao, Dscho