From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 28 Feb 2008 11:26:55 GMT
Subject: Re: [PATCH 6/9] Completely move out worktree setup from setup_git_directory_gently()
Message-ID: <alpine.LSU.1.00.0802281124420.22527@racer.site>
In-Reply-To: <20080227163934.GA28084@laptop>

Hi,

On Wed, 27 Feb 2008, Nguyễn Thái Ngọc Duy wrote:

> This was impossible earlier because git_dir can be relative. Now that
> git_dir is absolute, I see no reason for worktree setup inside
> setup_git_directory_gently().

I do see it, though.  Why make the users work harder?  If you want to get 
the git directory, chances are that you want to work with a worktree, too.

And you really cannot properly separate worktree detection from git 
directory detection: in most of the cases, you will find them at the 
_same_ time (if .git/ is the git directory, the working directory is .).

So I am mildly negative on the thrust of your patch series.

Ciao,
Dscho