From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 26 Feb 2008 15:42:55 GMT
Subject: Re: [PATCH] Fix premature free of ref_lists while writing temporary refs to file
Message-ID: <alpine.LSU.1.00.0802261542080.22527@racer.site>
In-Reply-To: <200802261635.51407.johan@herland.net>

Hi,

On Tue, 26 Feb 2008, Johan Herland wrote:

> We cannot call write_ref_sha1() from within a for_each_ref() callback, 
> since it will free() the ref_list that the for_each_ref() is currently 
> traversing.
> 
> Therefore rewrite setup_tmp_ref() to not call write_ref_sha1(), as 
> already hinted at in a comment.

I guess the reason was to use a much of an API as possible.

If you already avoid that, why not write into .git/packed-refs directly?

Ciao,
Dscho