From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 26 Feb 2008 11:18:39 GMT
Subject: Re: [PATCH] filter-branch documentation: non-zero exit status in command abort the filter
Message-ID: <alpine.LSU.1.00.0802261116570.17164@racer.site>
In-Reply-To: <1203992071-957-1-git-send-email-cmarcelo@gmail.com>

Hi,

On Mon, 25 Feb 2008, Caio Marcelo de Oliveira Filho wrote:

> Since commit 8c1ce0f46b85d40f215084eed7313896300082df filter-branch 
> fails when a <command> has a non-zero exit status. This commit makes it 
> clear in the documentation and also fixes the parent-filter example, 
> that was incorrectly returning non-zero when the commit being tested 
> wasn't the one to be rewritten.

I thought that we had that already in the man page, but you're right: we 
did not.

> ---------------------------------------------------------------------------
> +----------------------------------------------------------------------------
>  git filter-branch --parent-filter \
> -	'cat; test $GIT_COMMIT = <commit-id> && echo "-p <graft-id>"' HEAD
> ---------------------------------------------------------------------------
> +	'test $GIT_COMMIT = <commit-id> && echo "-p <graft-id>" || cat' HEAD
> +----------------------------------------------------------------------------

Yes, makes sense.

Ciao,
Dscho