From: Johannes Schindelin Date: Thu, 21 Feb 2008 20:57:15 GMT Subject: Re: [PATCH] A test for commit --amend allowing changing of a very empty commit message Message-ID: In-Reply-To: <20080221203506.GA20143@steel.home> Hi, On Thu, 21 Feb 2008, Alex Riesen wrote: > Junio C Hamano, Thu, Feb 21, 2008 21:23:10 +0100: > > Alex Riesen writes: > > > > > > Well, it fails... In current master > > > > Then please mark it with test_expect_failure. > > That's because I expect it to be fixed (in the next mail) AFAICT the preferred procedure is to add a patch demonstrating the failure, with test_expect_failure, and another patch fixing it, replacing the _failure with _success. Ciao, Dscho