From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 19 Feb 2008 13:01:26 GMT
Subject: Re: [PATCH 2/5] Improve message-id generation flow control for format-patch
Message-ID: <alpine.LSU.1.00.0802191300510.30505@racer.site>
In-Reply-To: <alpine.LNX.1.00.0802182254110.5816@iabervon.org>

Hi,

On Mon, 18 Feb 2008, Daniel Barkalow wrote:

> diff --git a/revision.h b/revision.h
> index 8572315..e3559d0 100644
> --- a/revision.h
> +++ b/revision.h
> @@ -74,7 +74,7 @@ struct rev_info {
>  	struct log_info *loginfo;
>  	int		nr, total;
>  	const char	*mime_boundary;
> -	const char	*message_id;
> +	char		*message_id;
>  	const char	*ref_message_id;
>  	const char	*add_signoff;
>  	const char	*extra_headers;

Mini-nit: technically, ref_message_id should be "char *", too.

Ciao,
Dscho