From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 17 Feb 2008 19:27:16 GMT
Subject: Re: warning: no common commits - slow pull
Message-ID: <alpine.LSU.1.00.0802171925330.30505@racer.site>
In-Reply-To: <7vhcg71n9u.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 17 Feb 2008, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Sat, 16 Feb 2008, Daniel Barkalow wrote:
> >
> >> I wonder if the problem is that something isn't getting reinitialized 
> >> for the second connection. It's not a separate invocation of 
> >> fetch-pack, and I can't say for sure that it's sending the right info 
> >> to the server when the statics in builtin-fetch-pack.c are left over 
> >> from the earlier call. This would particularly explain the 
> >> information that hitting ctrl-c and trying again fixes it.
> >
> > Oh, that should be it!  After all, the code in get_rev() in 
> > builtin-fetch-pack.c marks commits as SEEN and COMMON and POPPED.
> 
> I seem to be slow today, but how does that explain that the problem is 
> reported only by Len so far?

Hmm.  The code I was referencing is only in "next" so far, right?  And 
AFAICT it only occurs when you are fetching something which autofetches 
tags, right?

But thinking about this again: do we reuse the connection also for 
automatic tag fetching?  If not, my whole reasoning is wrong.

Ciao,
Dscho