From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 17 Feb 2008 15:15:43 GMT
Subject: Re: [RFC] sending errors to stdout under $PAGER
Message-ID: <alpine.LSU.1.00.0802171515190.30505@racer.site>
In-Reply-To: <20080217144854.56fcb98d.froese@gmx.de>

Hi,

On Sun, 17 Feb 2008, Edgar Toernig wrote:

> Junio C Hamano wrote:
> >
> > +	FILE *outto = (pager_in_use() ? stdout : stderr);
> > +
> >  	vsnprintf(msg, sizeof(msg), err, params);
> > -	fprintf(stderr, "%s%s\n", prefix, msg);
> > +	fprintf(outto, "%s%s\n", prefix, msg);
> >
> > What do people think?  Have I overlooked any downsides?
> 
> Wouldn't it be better/safer to redirect stderr to the pager
> in the first place?
> 
> [...]
>
>          /* return in the child */
>         if (!pid) {
>                 dup2(fd[1], 1);
> +               dup2(fd[1], 2);
>                 close(fd[0]);
>                 close(fd[1]);
>                 return;
>         }

I like it.

Ciao,
Dscho