From: Johannes Schindelin <johannes.schindelin-mmb7mzphnfy@public.gmane.org>
Date: Tue, 05 Feb 2008 22:21:58 GMT
Subject: Re: [PATCH v2] compat: Add simplified merge sort implementation from glibc
Message-ID: <alpine.LSU.1.00.0802052220500.8543@racer.site>
In-Reply-To: <20080205211044.GP26392-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>


Hi,

On Tue, 5 Feb 2008, Brian Downing wrote:

> diff --git a/compat/qsort.c b/compat/qsort.c
> new file mode 100644
> index 0000000..8663889
> --- /dev/null
> +++ b/compat/qsort.c
> @@ -0,0 +1,60 @@
> +#include "../git-compat-util.h"
> +
> +/* This merge sort implementation is simplified from glibc's. */
> +static void msort_with_tmp(void *b, size_t n, size_t s,

Didn't you forget to include the original copyright, as well as yours?

BTW if these 60 lines have code that is really faster than Microsoft's 
implementation of a sort, it is really fascinating to me.

Ciao,
Dscho