From: Johannes Schindelin Date: Tue, 05 Feb 2008 15:21:45 GMT Subject: Re: [PATCH-v2 4/4] git-commit: add a prepare-commit-msg hook Message-ID: In-Reply-To: <47A87DDC.5030708@gnu.org> Hi, On Tue, 5 Feb 2008, Paolo Bonzini wrote: > Johannes Schindelin wrote: > > > On Tue, 5 Feb 2008, Paolo Bonzini wrote: > > > > > The hook is not suppressed by the --no-verify option, and the exit > > > status is ignored by git. > > > > Umm. Should the exit status really be ignored? What _use_ would it > > be then? > > None; in the previous version I used an exit status of 1 to kill the > commit. But since this hook, unlike others, is meant to prepare things > for the user, the hook itself was not suppressed by --no-verify, only > checking the exit status. Junio thought it was a mess, so I now > completely ignore the exit status. > > I just wrote the above sentence because prepare-commit-msg is the only > git-commit hook whose exit status is ignored. I might be missing something, but should this not be solved by having the prepare-commit-msg exit 0? I mean, it is conceivable that such a bad error occurs in the hook that the commit should be stopped then and there. Ciao, Dscho