From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 04 Feb 2008 16:33:29 GMT
Subject: Re: [RFC,PATCH] Make git prune remove temporary packs that look like write failures
Message-ID: <alpine.LSU.1.00.0802041633190.7372@racer.site>
In-Reply-To: <alpine.LFD.1.00.0802041105170.2732@xanadu.home>

Hi,

On Mon, 4 Feb 2008, Nicolas Pitre wrote:

> On Mon, 4 Feb 2008, Johannes Schindelin wrote:
> 
> > On Mon, 4 Feb 2008, David Tweed wrote:
> > 
> > > +                       if(c>0 && c<4096 && stat(name, &status) == 0
> > > +                          && status.st_mtime < now - 600){
> > 
> > Please have spaces after the "if" and before the "{" (just imitate the 
> > style of the rest of the file).
> > 
> > Also, 10 minutes grace period for any ongoing fetch or repack seems a 
> > bit arbitrary.  Maybe default to 10 minutes, and introduce 
> > prune.packGracePeriod?
> > 
> > (Which reminds me that it might be useful to add a 
> > prune.looseObjectsGracePeriod to avoid having to type --expire= all 
> > the time?)
> 
> Please use the same parameter for both.  There is no need to have 
> separate settings.

Right.

Ciao,
Dscho