From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 04 Feb 2008 00:24:37 GMT
Subject: Re: [PATCH] Add platform-independent .git "symlink"
Message-ID: <alpine.LSU.1.00.0802040024030.7372@racer.site>
In-Reply-To: <7vwsplporv.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 3 Feb 2008, Junio C Hamano wrote:

> "Lars Hjemli" <hjemli@gmail.com> writes:
> 
> > Maybe this as a compromise?
> >
> > 	static char buf[PATH_MAX + 9];  /* "GITDIR: " + "\n"  */
> > ...
> > 	if (!len || buf[len - 1] != '\n')
> > 		return NULL;
> > 	buf[len - 1] = '\0';
> > 	if (prefixcmp(buf, "GITDIR: "))
> > 		return NULL;
> 
> Perhaps that is easier to read.
> 
> For now I haven't picked up any of the "how about this way"
> revisions.

Yeah, I think all my comments have been addressed...  Lars, care to send a 
new version?

Thanks,
Dscho