From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 31 Jan 2008 11:07:06 GMT
Subject: Re: [PATCH 2/2] git-filter-branch.sh: don't use --default when calling rev-list
Message-ID: <alpine.LSU.1.00.0801311106300.23907@racer.site>
In-Reply-To: <7vwspqcple.fsf@gitster.siamese.dyndns.org>

Hi,

On Thu, 31 Jan 2008, Junio C Hamano wrote:

> Andreas Ericsson <ae@op5.se> writes:
> 
> > Well, if there's no filter specified it has nothing to do, so erroring 
> > out in the no-arguments-at-all case would be sensible.
> 
> Actually, not erroring out but just returning doing nothing (if there 
> truly isn't anything to do -- iow, the filtering operation turns out to 
> be identity function) would be more sensible.
> 
> No filter does not necessarily mean identity, by the way.  Think 
> "grafts" ;-).

Yeah.  Having slept over it, I agree that there is a sensible default 
action, and only one.

Ciao,
Dscho