From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 18 Jan 2008 12:14:48 GMT
Subject: Re: [PATCH] http-push: fix double free()
Message-ID: <alpine.LSU.1.00.0801181213220.5731@racer.site>
In-Reply-To: <20080118063417.GB22089@glandium.org>

Hi,

On Fri, 18 Jan 2008, Mike Hommey wrote:

> On Thu, Jan 17, 2008 at 07:45:11PM +0000, Johannes Schindelin wrote:
> > 
> > There was an extra free(url) in remote_exists() (both if clauses 
> > before that contain a free(url) already), which resulted in a crash on 
> > Windows.
> 
> Mmmmmm the free(url) you remove has been added in 3a462bc9 and the 
> free(url) in the if clauses before have been removed in the same commit. 
> I fail to see how that could lead to a double free().
> 
> Actually, I do see how, because git show 64be904 displays an obviously 
> wrong remote_exists. OTOH, neither next, master nor pu have such code...

Ah, sorry.  I was working on an old git branch, it seems.  Will try with a 
newer one (to see if issue 71 persists).

Ciao,
Dscho