From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 10 Jan 2008 12:05:50 GMT
Subject: Re: [PATCH] bundle, fast-import: detect write failure
Message-ID: <alpine.LSU.1.00.0801101204120.31053@racer.site>
In-Reply-To: <874pdmhxha.fsf@rho.meyering.net>

Hi,

On Thu, 10 Jan 2008, Jim Meyering wrote:

> I noticed some unchecked writes.  This fixes them.

Thank you.

However, you also have this:

> -	close(keep_fd);
> +	if (close(keep_fd))
> +		die("failed to write keep file");

I recently read an article which got me thinking about close().  The 
author maintained that many mistakes are done by being overzealously 
defensive; die()ing in case of a close() failure (when open() succeeded!) 
might be just wrong.

Ciao,
Dscho