From: Johannes Schindelin Date: Wed, 09 Jan 2008 13:40:46 GMT Subject: Re: [PATCH] Fix the MacOS X compile of gitk by pinching po2msg.sh from git-gui Message-ID: In-Reply-To: <20080109132953.GA12489@hashpling.org> Hi, On Wed, 9 Jan 2008, Charles Bailey wrote: > Make the behaviour of a top level make NO_MSGFMT=Yes consistent when > performing the subdirectory builds in gitk-git and git-gui. > > Signed-off-by: Charles Bailey > --- > gitk-git/Makefile | 7 ++++++- > {git-gui => gitk-git}/po/.gitignore | 0 > {git-gui => gitk-git}/po/po2msg.sh | 0 > 3 files changed, 6 insertions(+), 1 deletions(-) > copy {git-gui => gitk-git}/po/.gitignore (100%) > copy {git-gui => gitk-git}/po/po2msg.sh (100%) Since gitk and git-gui are separate projects (pulled at irregular intervals into git.git), your patch looks sane, but would be better done as a patch against gitk.git. Ciao, Dscho