From: Steven Drake <sdrake@xnet.co.nz>
Date: Mon, 11 Jan 2010 07:12:57 GMT
Subject: Re: [PATCH 2/2] Use $(git rev-parse --show-toplevel) in cd_to_toplevel()
Message-ID: <alpine.LNX.2.00.1001111354470.7728@vqena.qenxr.bet.am>
In-Reply-To: <20100110101154.GA18138@progeny.tock>

On Sun, 10 Jan 2010, Jonathan Nieder wrote:
> Why not 'cdup=$(git rev-parse --show-toplevel) && cd "$cdup"'
> unconditionally?  That would avoid having to look for the .git dir
> twice and would mirror setup_work_tree() a bit more closely.

Depends on what you think is the lesser of to evials, running 
'git rev-parse' twice or preforming a cd when theres no need to, but after
looking at setup_work_tree() I agree with you and will send in a new patch.

-- 
Steven