From: Daniel Barkalow <barkalow@iabervon.org>
Date: Tue, 08 Dec 2009 17:17:21 GMT
Subject: Re: [PATCH v2 1/3] refactor ref status logic for pushing
Message-ID: <alpine.LNX.2.00.0912081158040.14365@iabervon.org>
In-Reply-To: <20091208223543.c7f88afe.rctay89@gmail.com>

On Tue, 8 Dec 2009, Tay Ray Chuan wrote:

> Move the logic that detects up-to-date and non-fast-forward refs to a
> new function in remote.[ch], set_ref_status_for_push().

Is there some reason to not have set_ref_status_for_push() be static in 
transport.c now? (Sorry for not suggesting this before.)

Other than that, it looks good to me.

I think it might be a good idea to have it generate a peer ref for refs 
that don't have one when mirror is used, which would eliminate a couple 
more lines, but there's no reason that has to be done in the same patch.

	-Daniel
*This .sig left intentionally blank*