From: Daniel Barkalow <barkalow@iabervon.org>
Date: Wed, 02 Dec 2009 16:23:56 GMT
Subject: Re: [PATCH] transport-helper: remove duplicate free()
Message-ID: <alpine.LNX.2.00.0912021120440.14365@iabervon.org>
In-Reply-To: <20091202153950.c18095b7.rctay89@gmail.com>

On Wed, 2 Dec 2009, Tay Ray Chuan wrote:

> Remove the free() invocation on transport->data in release_helper(), as
> disconnect_helper() has already done so.

You need to remove the one in disconnect_helper, because the entire point 
of disconnect_helper as opposed to release_helper is to *not* free that 
memory. If you remove this one, you'll access freed memory in any case 
where the helper has to be quit and restarted.

	-Daniel
*This .sig left intentionally blank*