From: Daniel Barkalow Date: Fri, 06 Nov 2009 23:12:52 GMT Subject: Re: [PATCH v3 08/12] Allow helper to map private ref names into normal names Message-ID: In-Reply-To: <1257547966-14603-9-git-send-email-srabbelier@gmail.com> On Fri, 6 Nov 2009, Sverre Rabbelier wrote: > From: Daniel Barkalow > > This allows a helper to say that, when it handles "import > refs/heads/topic", the script it outputs will actually write to > refs/svn/origin/branches/topic; therefore, transport-helper should > read it from the latter location after git-fast-import completes. > --- > > New in this series. > Daniel, you did not include a S-o-b, I assume because you > mean to add documentation? I wasn't terribly convinced I'd actually implemented it correctly, since I couldn't test it essentially at all; I was just going for something that gave the right idea. At the very least, it needs documentation and memory leaks fixed (the refspec strings read from the helper, and the refspec structs and array on freeing the helper data). Is this actually working with your helper? Occasionally I write code that just works without any testing, but I don't usually expect it. :) -Daniel *This .sig left intentionally blank*