From: Daniel Barkalow <barkalow@iabervon.org>
Date: Wed, 04 Nov 2009 22:27:24 GMT
Subject: Re: [PATCH v2 11/13] Allow helpers to request the path to the .git directory
Message-ID: <alpine.LNX.2.00.0911041723010.14365@iabervon.org>
In-Reply-To: <fabb9a1e0911041406tce0956ai2ad3fe6cfbdc546d@mail.gmail.com>

On Wed, 4 Nov 2009, Sverre Rabbelier wrote:

> Heya,
> 
> On Wed, Nov 4, 2009 at 22:35, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > I thought we cd into the repository in the middle of clone somewhere,
> > before running stuff.
> 
> It does, but not soon enough, that is, not before I needed it in my helper.
> 
> > In any case, I think it would be good to have
> > something like that, but I think maybe we should tell it where it can put
> > its status files, rather than telling it where the .git dir is.
> 
> Yes, that would probably be a good idea, .git/info/remote-<vcs>/<alias> perhaps?

Seems reasonable to me, unless we make it .git/info/remote-<vcs>, and tell 
helper authors to deal with having different imports not conflict with 
each other.

> > It would
> > also be nice if this is the absolute path that gfi will base a relative
> > path for the "marks" options on when importing.
> 
> The marks option has been dumped in favor of 'feature import-marks='
> and 'feature export-marks=' which will be in the reroll of
> sr/gfi-options.

Right, but the values of those have to be paths, and I think they should 
be relative paths, relative to the helper's state directory.

	-Daniel
*This .sig left intentionally blank*