From: Daniel Barkalow <barkalow@iabervon.org>
Date: Sun, 01 Nov 2009 20:16:20 GMT
Subject: Re: Fw: git-core: SIGSEGV during {peek,ls}-remote on HTTP remotes.
Message-ID: <alpine.LNX.2.00.0911011504460.14365@iabervon.org>
In-Reply-To: <fabb9a1e0911010646v2043bdb7l9215f1114e9e8385@mail.gmail.com>

On Sun, 1 Nov 2009, Sverre Rabbelier wrote:

> Heya,
> 
> On Sun, Nov 1, 2009 at 05:27, Junio C Hamano <gitster@pobox.com> wrote:
> >  - Should we fix get_helper() in transport-helper.c, instead of touching
> >   ls-remote.c like this patch does?
> 
> Probably, yes.

If we change the ls-remote.c case, it becomes impossible for a struct 
transport to ever have a NULL remote field. And the change to ls-remote 
removes a special case. I'd go so far as to say that ls-remote.c should 
provide a struct remote, and transport_get should enforce that there's a 
struct remote.

	-Daniel
*This .sig left intentionally blank*