From: Daniel Barkalow <barkalow@iabervon.org>
Date: Tue, 13 Oct 2009 21:41:48 GMT
Subject: Re: [RFC PATCH v2 08/16] remote-helpers: Support custom transport options
Message-ID: <alpine.LNX.2.00.0910131732260.32515@iabervon.org>
In-Reply-To: <20091013205258.GD9261@spearce.org>

On Tue, 13 Oct 2009, Shawn O. Pearce wrote:

> Daniel Barkalow <barkalow@iabervon.org> wrote:
> > On Tue, 13 Oct 2009, Shawn O. Pearce wrote:
> > > > > +'option thin'::
> > > > > +	Transfer the data as a thin pack if possible.
> > > > 
> > > > Does anyone still use non-default thinness? 
> > > 
> > > Its a command line option on the porcelain.
> > 
> > Actually, the command line supports turning it on, and it defaults to on. 
> > So I think your helper can safely assume that it's on. :)
> 
> For fetch it defaults to "on", but for push I think it defaults
> to "off".  Turning it on when pushing on a low bandwidth network
> connection might actually be useful to an end-user.

Nope, on ~line 849 of transport.c, it gets set for all native-transport 
handlers, and never gets turned off. Looks like a misconversion 2 years 
ago defaulting "data->thin" to 1 instead of 0, but it seems not to have 
caused problems.

	-Daniel
*This .sig left intentionally blank*