From: Julian Phillips Date: Thu, 17 Sep 2009 01:30:38 GMT Subject: Re: [RFC/PATCH v2] fetch: Speed up fetch by rewriting find_non_local_tags Message-ID: In-Reply-To: On Thu, 17 Sep 2009, Julian Phillips wrote: > On Wed, 16 Sep 2009, Junio C Hamano wrote: > >> I am just curious. How would a "just one item lookbehind" code perform >> compared to this one? > > The code you wrote ealier is almost the same as the string_list version, > ~ 4.3s, so very marginally slower but a lot less code change. Personally > I'd be happy with any of the three, so long as I don't have to wait 30s to > find out that nothing's happened at $dayjob anymore ;) FWIW: I've Just modified my v2 patch to make use of the requirement that the peeled ref immediately follow the base ref, and it's now ~4.1s and should use less memory than the original too. I won't bother posting it unless someone thinks it worth it though. -- Julian --- Taxes, n.: Of life's two certainties, the only one for which you can get an extension.