From: Boyd Lynn Gerber Date: Tue, 16 Sep 2008 23:25:46 GMT Subject: Re: [RFC/PATCH] Use compatibility regex library for OSX/Darwin Message-ID: In-Reply-To: Hello, On Tue, 16 Sep 2008, Brandon Casey wrote: > Arjen Laarhoven wrote: >> The standard libc regex library on OSX does not support alternation >> in POSIX Basic Regular Expression mode. This breaks the diff.funcname >> functionality on OSX. >> >> To fix this, we use the GNU regex library which is already present in >> the compat/ diretory for the MinGW port. However, simply adding compat/ >> to the COMPAT_CFLAGS variable causes a conflict between the system >> fnmatch.h and the one present in compat/. To remedy this, move the >> regex and fnmatch functionality to their own subdirectories in compat/ >> so they can be included seperately. > > I wonder if this is the right fix? Right now the GNU regex library is > necessary for Darwin, FreeBSD and AIX. I can add IRIX6.5 and Solaris 7 > to that list. Have newer Solaris's been tested yet? (Jeff?) I wonder if > the new test which triggers this flaw has been tested on the other > non-GNU platforms in the Makefile which have not been updated. Boyd > Lynn Gerber and his 12 platforms comes to mind. > > It seems POSIX only mentions alternation under Extended Regular Expressions. > Likewise for the vertical-line character '|'. Someone forwarded me this email and asked if I had tested it. I have not. Where is the easiest place to get it to test with the various platforms? I will check it out on 3-5 of them. I now have 1.6.0.2 on 5 platforms running and working. I have not had the time to get it on the other's yet. -- Boyd Gerber ZENEZ 1042 East Fort Union #135, Midvale Utah 84047