From: Daniel Barkalow <barkalow@iabervon.org>
Date: Wed, 22 Apr 2009 18:24:07 GMT
Subject: Re: Removing duplicated code between builtin-send-pack.c and transport.c
Message-ID: <alpine.LNX.1.00.0904221407160.10753@iabervon.org>
In-Reply-To: <09511913-0ED3-41C0-A4F0-9F2D452C00D7@petdance.com>

On Wed, 22 Apr 2009, Andy Lester wrote:

> There's a ton of code duplicated between transport.c and builtin-send-pack.c,
> from print_push_status() and its static helpers.
> 
> Is there a reason NOT to refactor it out of the builtin and use the 
> transport? 

I think the builtin should actually just be deprecated and eventually 
removed. As far as I know, nothing actually runs "git send-pack" rather 
than calling send_pack(), but I left the builtin entry point, along with 
its helpers, just in case.

If you're interested in reorganizing things there, I think it would be 
best to move send_pack() to a new send-pack.c, such that 
builtin-send-pack.c can go away entirely.

	-Daniel
*This .sig left intentionally blank*