From: Daniel Barkalow <barkalow@iabervon.org>
Date: Thu, 19 Feb 2009 22:41:42 GMT
Subject: Re: [PATCH 2/4] format-patch: track several references
Message-ID: <alpine.LNX.1.00.0902191734110.19665@iabervon.org>
In-Reply-To: <5a41305e9103c870e8cae95dcf58655c275aba9b.1235078708.git.trast@student.ethz.ch>

On Thu, 19 Feb 2009, Thomas Rast wrote:

> Currently, format-patch can only track a single reference (the
> In-Reply-To:) for each mail.  To ensure proper threading, we should
> list all known references for every mail.
> 
> Change the rev_info.ref_message_id field to a string_list

It would be nice to change the field name to "ref_message_ids", which is 
more likely to suggest that it's a list of ids, rather than a single id 
stored strangely.

Aside from that, parts 2-4 look good to me (I'm not up on reviewing shell 
code).

	-Daniel
*This .sig left intentionally blank*