From: Daniel Barkalow Date: Wed, 25 Jun 2008 06:11:35 GMT Subject: Re: [PATCH] clone: create intermediate directories of destination repo Message-ID: In-Reply-To: <20080625054134.GB2209@sigill.intra.peff.net> On Wed, 25 Jun 2008, Jeff King wrote: > On Tue, Jun 24, 2008 at 11:20:07AM -0400, Daniel Barkalow wrote: > > > > I am worried that it is too clever. I didn't see an obvious way for > > > work_tree and git_dir to not have that property, but I think it is still > > > worth somebody double-checking. > > > > I think you can specify git_dir and work_tree on the command line, and set > > them to whatever you want, although I now don't remember whether they're > > actually both followed for clone (I tried to match the shell version, > > whose behavior didn't make too much sense to me). > > The git_dir variable is always set from the directory provided on the > command line. However, the work_tree can be overridden by the > environment. For some reason I missed the giant 'work_tree = > getenv("GIT_WORK_TREE")' when I looked before. But that means that they > are not necessarily related. > > So my original patch was too clever. Here is the less clever patch, with > an extra test that would break with the clever version. Looks good, thanks. Acked-by: Daniel Barkalow -Daniel *This .sig left intentionally blank*